From 75c3d290f10b1b82bdec72ea803f76d22c4d4e8e Mon Sep 17 00:00:00 2001 From: Keir Fraser Date: Wed, 8 Apr 2009 14:43:12 +0100 Subject: [PATCH] x86 hvm: Remove the extra IS_PRIV_FOR() checks I added to do_hvm_op(). Actually this is already done by rcu_lock_target_domain_by_id(). Oops. Signed-off-by: Keir Fraser --- xen/arch/x86/hvm/hvm.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index b8b1579041..82b99ab761 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -2439,10 +2439,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg) if ( rc != 0 ) return rc; - rc = -EPERM; - if ( (curr_d != d) && !IS_PRIV_FOR(curr_d, d) ) - goto param_fail; - rc = -EINVAL; if ( !is_hvm_domain(d) ) goto param_fail; @@ -2621,10 +2617,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg) if ( rc != 0 ) return rc; - rc = -EPERM; - if ( !IS_PRIV_FOR(curr_d, d) ) - goto param_fail2; - rc = -EINVAL; if ( !is_hvm_domain(d) ) goto param_fail2; @@ -2663,10 +2655,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg) if ( rc != 0 ) return rc; - rc = -EPERM; - if ( !IS_PRIV_FOR(curr_d, d) ) - goto param_fail3; - rc = -EINVAL; if ( !is_hvm_domain(d) ) goto param_fail3; @@ -2723,10 +2711,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg) if ( rc != 0 ) return rc; - rc = -EPERM; - if ( !IS_PRIV_FOR(curr_d, d) ) - goto param_fail4; - rc = -EINVAL; if ( !is_hvm_domain(d) ) goto param_fail4; -- 2.30.2